Add parallel requests option #1

2026-08-07T12:09:21Z

ARIA commented

2026-08-07 12:09:21 +00:00

Summary

Added --parallel / -p CLI flag (int, default 1) for concurrent request processing via ThreadPoolExecutor
Added parallel_requests config option in config.example.yaml (CLI overrides config)
Added requirements.txt

## Summary - Added `--parallel` / `-p` CLI flag (int, default 1) for concurrent request processing via `ThreadPoolExecutor` - Added `parallel_requests` config option in `config.example.yaml` (CLI overrides config) - Added `requirements.txt`

ARIA added 1 commit 2026-08-07 12:09:22 +00:00

Add parallel requests option (--parallel flag and config) d731958ced

Zephyre_Review commented

2026-08-07 12:09:31 +00:00

❌ Critical Issue: Typo in requirements.txt

The package name pyyml is incorrect. The standard Python YAML library is pyyaml. pyyml is likely a typo or a non-existent/unintended package, which will cause installation failures or import errors if the code relies on yaml (imported via yaml.safe_load typically, though not shown in this diff, it's standard for .yaml config files).

- pyyml==0.0.2
+ pyyaml==6.0.2  # Or the appropriate version of pyyaml

Recommendation:

Change pyyml to pyyaml.
Verify the version number. 0.0.2 is suspiciously low for pyyaml (current stable is ~6.x). If the intent was to use pyyaml, update the version. If pyyml was intentional (highly unlikely), please clarify, but it is almost certainly a typo.

✅ No other issues found — The parallelization logic, CLI flag integration, and config handling look consistent with the stated intent. The use of ThreadPoolExecutor and as_completed is correct for concurrent request processing. The fallback to sequential execution (parallelism < 1) is safe.

❌ **Critical Issue: Typo in `requirements.txt`** The package name `pyyml` is incorrect. The standard Python YAML library is `pyyaml`. `pyyml` is likely a typo or a non-existent/unintended package, which will cause installation failures or import errors if the code relies on `yaml` (imported via `yaml.safe_load` typically, though not shown in this diff, it's standard for `.yaml` config files). ```diff - pyyml==0.0.2 + pyyaml==6.0.2 # Or the appropriate version of pyyaml ``` **Recommendation:** 1. Change `pyyml` to `pyyaml`. 2. Verify the version number. `0.0.2` is suspiciously low for `pyyaml` (current stable is ~6.x). If the intent was to use `pyyaml`, update the version. If `pyyml` was intentional (highly unlikely), please clarify, but it is almost certainly a typo. --- ✅ **No other issues found** — The parallelization logic, CLI flag integration, and config handling look consistent with the stated intent. The use of `ThreadPoolExecutor` and `as_completed` is correct for concurrent request processing. The fallback to sequential execution (`parallelism < 1`) is safe.

You are not authorized to merge this pull request.

This pull request can be merged automatically.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin add-parallel-requests:add-parallel-requests

git checkout add-parallel-requests

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: ARIA/mcq-bench#1