Pakobbix/rpg-companion-sillytavern
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes #16: Code quality enhancement Part 3 #17

Merged
Pakobbix merged 1 commits from issue-16-code-quality-enhancements into main 2026-07-12 13:31:06 +00:00
Conversation 1 Commits 1 Files Changed 8
+649 -464
ARIA commented 2026-07-12 13:25:19 +00:00
Collaborator
Copy Link
Copy Source

Closes #16

3.1 Duplicate Code:

  • Settings defaults consolidated: config.js is now single source of truth, state.js imports from it (~300 lines eliminated)
  • Validator factory: createStringValidator() unifies sanitizeLocationName/sanitizeItemName
  • Refactored promptBuilder: extracted getCharacterCardsInfo into focused helper functions

3.2 Error Handling:

  • jsonRepair.js silent failures now log to console.debug for troubleshooting

3.3 Type Safety:

  • Return types already standardized on null — verified during review

3.4 Testing:

  • Fixed ESM support (babel.config.json + jest.config.cjs transform)
  • Added security.test.js with 24 tests for validator factory and security utilities
  • Total: 78 tests passing (up from 54)
Closes #16 **3.1 Duplicate Code:** - Settings defaults consolidated: config.js is now single source of truth, state.js imports from it (~300 lines eliminated) - Validator factory: createStringValidator() unifies sanitizeLocationName/sanitizeItemName - Refactored promptBuilder: extracted getCharacterCardsInfo into focused helper functions **3.2 Error Handling:** - jsonRepair.js silent failures now log to console.debug for troubleshooting **3.3 Type Safety:** - Return types already standardized on null — verified during review **3.4 Testing:** - Fixed ESM support (babel.config.json + jest.config.cjs transform) - Added security.test.js with 24 tests for validator factory and security utilities - Total: 78 tests passing (up from 54)
ARIA added 1 commit 2026-07-12 13:25:19 +00:00
Fixes #16: Code quality enhancements Part 3 28802b1ad7 
- Consolidate settings defaults: config.js is now single source of truth,
  state.js imports from config.js (eliminates ~300 lines of duplication)
- Validator factory: createStringValidator() unifies sanitizeLocationName/
  sanitizeItemName with configurable rules (blocked names, max length, rejects)
- Refactor promptBuilder: Extract getCharacterCardsInfo into buildNarratorCardInfo,
  buildGroupCardInfo, buildSingleCardInfo, appendCharacterFields
- Error handling: jsonRepair.js silent failures now log to console.debug
- Testing: Fix ESM support (babel.config.json + jest.config.cjs transform),
  add security.test.js with 24 tests for validator factory and security utilities
- Total: 78 tests passing (was 54)
Zephyre_Review commented 2026-07-12 13:25:34 +00:00
Collaborator
Copy Link
Copy Source

✅ No issues found — changes look consistent with the stated intent. Ready to be merged.

✅ No issues found — changes look consistent with the stated intent. Ready to be merged.
Pakobbix merged commit f00475cb65 into main 2026-07-12 13:31:06 +00:00
Pakobbix deleted branch issue-16-code-quality-enhancements 2026-07-12 13:31:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
ARIA (Adaptive Responsive Intelligent Assistant) Zephyre_Review Pakobbix (Pakobbix)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Pakobbix/rpg-companion-sillytavern#17