refactor: remove redundant Edit Trackers button from hamburger menu

Remove duplicate "Edit Trackers" button from hamburger menu since there's
already a Tracker Settings button in the dashboard header.

Changes:
- Removed "Edit Trackers" button from template.html hamburger menu
- Updated Settings button to full width (removed .rpg-btn-half class)
- Changed dashboard button ID from 'rpg-dashboard-tracker-settings' to
  'rpg-open-tracker-editor' to become the canonical button
- Removed redundant event handler in dashboardIntegration.js that was
  clicking the old hamburger button

Benefits:
- Reduces UI clutter in hamburger menu
- Single source of truth for Tracker Settings button (dashboard header)
- Existing code in trackerEditor.js, infoBoxWidgets.js continues to work
  via jQuery event delegation on ID 'rpg-open-tracker-editor'

Technical Notes:
- jQuery delegation $(document).on('click', '#rpg-open-tracker-editor', ...)
  works for any element with that ID, not just a specific one
- No changes needed to trackerEditor.js or widget disabled state handlers
- Dashboard button is now the canonical "Edit Trackers" trigger

Related: Hamburger menu UI, dashboard header controls
This commit is contained in:
Lucas 'Paperboy' Rose-Winters
2025-11-06 22:37:20 +11:00
parent aa0dd55fb1
commit 4dd71c95c7
3 changed files with 5 additions and 20 deletions
+2 -5
View File
@@ -64,12 +64,9 @@
<i class="fa-solid fa-sync"></i> Refresh RPG Info
</button>
<!-- Settings and Edit Trackers Buttons Row -->
<!-- Settings Button -->
<div class="rpg-settings-buttons-row">
<button id="rpg-open-tracker-editor" class="rpg-btn-settings rpg-btn-half">
<i class="fa-solid fa-sliders"></i> Edit Trackers
</button>
<button id="rpg-open-settings" class="rpg-btn-settings rpg-btn-half">
<button id="rpg-open-settings" class="rpg-btn-settings">
<i class="fa-solid fa-gear"></i> Settings
</button>
</div>