From 39ec36f10536be93e3f83931f5b7d59d7fa8356b Mon Sep 17 00:00:00 2001
From: Lucas 'Paperboy' Rose-Winters <lucas@sanguinehost.com>
Date: Fri, 17 Oct 2025 15:06:53 +1100
Subject: [PATCH] =?UTF-8?q?feat(inventory):=20add=20automatic=20v1?=
 =?UTF-8?q?=E2=86=92v2=20migration=20on=20settings/chat=20load?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Integrate inventory migration into persistence layer:
- Call migrateInventory() automatically when loading settings
- Call migrateInventory() automatically when loading chat data
- Save migrated data back to persistence immediately
- Update default reset inventory to v2 format
- Add console logging for migration status

Migration behavior:
- Only runs when FEATURE_FLAGS.useNewInventory is true
- Automatically detects v1 string format and converts to v2
- Handles null/undefined/empty/malformed data gracefully
- Logs migration source (v1, null, default) to console
- Persists migrated inventory immediately after conversion
- Migration runs once per load - subsequent loads see v2

Migration scenarios:
1. Old save with v1 string → migrates to v2.onPerson, saves
2. No save data → uses v2 defaults from state.js
3. Already v2 → no migration, no save
4. Chat data with v1 → migrates to v2, updates chat metadata

Changes:
- MODIFIED: src/core/persistence.js (+29 lines)
  - Updated loadSettings() with migration hook
  - Updated loadChatData() with migration hook
  - Changed default reset inventory from 'None' to v2 object

Part of inventory system v2 implementation
Dependencies: inventory types and migration utility
---
 src/core/persistence.js | 34 ++++++++++++++++++++++++++++++++--
 1 file changed, 32 insertions(+), 2 deletions(-)

diff --git a/src/core/persistence.js b/src/core/persistence.js
index 64e838e..e143bdd 100644
--- a/src/core/persistence.js
+++ b/src/core/persistence.js
@@ -11,13 +11,16 @@ import {
     lastGeneratedData,
     setExtensionSettings,
     updateExtensionSettings,
-    setLastGeneratedData
+    setLastGeneratedData,
+    FEATURE_FLAGS
 } from './state.js';
+import { migrateInventory } from '../utils/migration.js';
 
 const extensionName = 'third-party/rpg-companion-sillytavern';
 
 /**
  * Loads the extension settings from the global settings object.
+ * Automatically migrates v1 inventory to v2 format if needed.
  */
 export function loadSettings() {
     if (power_user.extensions && power_user.extensions[extensionName]) {
@@ -26,6 +29,16 @@ export function loadSettings() {
     } else {
         // console.log('[RPG Companion] No saved settings found, using defaults');
     }
+
+    // Migrate inventory if feature flag enabled
+    if (FEATURE_FLAGS.useNewInventory) {
+        const migrationResult = migrateInventory(extensionSettings.userStats.inventory);
+        if (migrationResult.migrated) {
+            console.log(`[RPG Companion] Inventory migrated from ${migrationResult.source} to v2 format`);
+            extensionSettings.userStats.inventory = migrationResult.inventory;
+            saveSettings(); // Persist migrated inventory
+        }
+    }
 }
 
 /**
@@ -94,6 +107,7 @@ export function updateMessageSwipeData() {
 
 /**
  * Loads RPG data from the current chat's metadata.
+ * Automatically migrates v1 inventory to v2 format if needed.
  */
 export function loadChatData() {
     if (!chat_metadata || !chat_metadata.rpg_companion) {
@@ -107,7 +121,13 @@ export function loadChatData() {
                 arousal: 0,
                 mood: '😐',
                 conditions: 'None',
-                inventory: 'None'
+                // Use v2 inventory format for defaults
+                inventory: {
+                    version: 2,
+                    onPerson: "None",
+                    stored: {},
+                    assets: "None"
+                }
             }
         });
         setLastGeneratedData({
@@ -136,5 +156,15 @@ export function loadChatData() {
         setLastGeneratedData({ ...savedData.lastGeneratedData });
     }
 
+    // Migrate inventory in chat data if feature flag enabled
+    if (FEATURE_FLAGS.useNewInventory && extensionSettings.userStats.inventory) {
+        const migrationResult = migrateInventory(extensionSettings.userStats.inventory);
+        if (migrationResult.migrated) {
+            console.log(`[RPG Companion] Chat inventory migrated from ${migrationResult.source} to v2 format`);
+            extensionSettings.userStats.inventory = migrationResult.inventory;
+            saveChatData(); // Persist migrated inventory to chat metadata
+        }
+    }
+
     // console.log('[RPG Companion] Loaded chat data:', savedData);
 }