fix: address PR review — flash state race, error paths, test robustness, nits
- server.py: claim the flash (state=bootloader) before spawning the task so the concurrent-request guard is effective immediately; guard the bundled image existence in the flash endpoint; single device.info() call per endpoint; 400 for refused flashes (409 stays for already-running); remove stale nvcurve-wireview-fw-*.bin temp files at startup - wireview_firmware.py: drain stderr in its own reader thread (a full pipe buffer would have hung the flash until timeout); chunked stdout reads instead of per-character read(2); BuildStruct field checks in dataclass order - wireview.py: document the intentional 0xF1 overlap between CMD_BOOTLOADER and SCREEN_RESUME_UPDATES (different command namespaces) - tests: check() now fails loudly under pytest (optional import, standalone runs unaffected); explicit reader-thread sync in test_enter_bootloader; less brittle flash-progress assertion; self-documenting checksum corruption in test_hex_parser - frontend: refreshFirmware in useCallback + effect deps; NaN% guard on flash.progress; explicit clear/keep masks in handleClear; WS firmware message reuses WireViewFlashProgress via Pick - docs: clarify that the dfu-util :leave modifier is what makes the device exit the bootloader and reboot; document the 400 vs 409 API contract; README now mentions per-pin readings, pin-imbalance gauge and fault clearing
This commit is contained in:
1 parent
dbb6856a6d
commit
6e87dcf862
8 files changed
+111
-55
No files matched your search
+2
-2
@@ -90,7 +90,7 @@ Flashing requires:
|
||||
- the `dfu-util` package (`sudo apt install dfu-util` / `sudo dnf install dfu-util` / …) — the card shows a warning when it is missing;
|
||||
- the udev rule above, which already covers the DFU bootloader (`0483:df11`).
|
||||
|
||||
The flash procedure: NVCurve sends the bootloader command over the serial port, the device reboots into its STM32 DFU bootloader (`0483:df11`), the bundled Intel-HEX image is flattened to a raw binary (gaps padded with `0xFF`) and downloaded with `dfu-util -d 0483:df11 -a 0 -s 0x08000000:leave -D <image>`. The device reboots on its own and the watchdog reconnects it; the card then re-checks and shows the new firmware. Progress is streamed live over the WebSocket.
|
||||
The flash procedure: NVCurve sends the bootloader command over the serial port, the device reboots into its STM32 DFU bootloader (`0483:df11`), the bundled Intel-HEX image is flattened to a raw binary (gaps padded with `0xFF`) and downloaded with `dfu-util -d 0483:df11 -a 0 -s 0x08000000:leave -D <image>`. The `:leave` modifier tells the device to exit the bootloader after the download, so it reboots into the new firmware on its own and the watchdog reconnects it; the card then re-checks and shows the new firmware. Progress is streamed live over the WebSocket.
|
||||
|
||||
> [!WARNING]
|
||||
> Flashing restarts the device into its bootloader and rewrites its flash. A power loss or unplug mid-flash can leave the device unbootable until it is reflashed manually. This is unofficial software, not affiliated with Thermal Grizzly — flash at your own risk.
|
||||
@@ -98,7 +98,7 @@ The flash procedure: NVCurve sends the bootloader command over the serial port,
|
||||
API:
|
||||
|
||||
- `GET /api/wireview/firmware` — device vs. bundled firmware, the verdict (`newer` | `same` | `unknown` | `downgrade` | `product_mismatch` | `too_old_for_noctua`), `dfu-util` availability, and the flash state;
|
||||
- `POST /api/wireview/firmware/flash` — `{"override": false}`; `override=true` is required for a downgrade or identical build. Returns `409` when the flash is refused or already running.
|
||||
- `POST /api/wireview/firmware/flash` — `{"override": false}`; `override=true` is required for a downgrade or identical build. Returns `400` when the flash is refused (product mismatch, Noctua floor, downgrade/same without `override=true`) and `409` when a flash is already running.
|
||||
|
||||
## Pin current imbalance warning
|
||||
|
||||
|
||||
Reference in new issue
Block a user